Dismiss all stale Github reviews#3382
Open
La0 wants to merge 2 commits into
Open
Conversation
marco-c
reviewed
May 22, 2026
| event=ReviewEvent.RequestChanges, | ||
| ) | ||
| else: | ||
| # Simply approve the pull request |
Collaborator
There was a problem hiding this comment.
the comment needs to be updated
marco-c
reviewed
May 22, 2026
Comment on lines
+70
to
+72
| logger.info( | ||
| "No publishable issue, no review nor comment published on Github." | ||
| ) |
Collaborator
There was a problem hiding this comment.
we might still want to add a comment maybe? So people know the review bot is done and it didn't find any issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR dismisses all previous reviews made by the bot, then only publishes a new review if some issues have been detected.
When no issue is found, nothing is published.
Site note: the current github app cannot load its own user information to identify itself (probably a scope missing), so I had to hardcode the bot's login in order to only dismiss its own reviews.